From 4c7b90233128c35fe7f0882983c67124d759c648 Mon Sep 17 00:00:00 2001
From: Matt Jankowski <matt@jankowski.online>
Date: Wed, 3 Jan 2024 11:35:35 -0500
Subject: [PATCH] Remove `fuubar` gem and custom rspec `--format` setting

Instead of specifying this at the project level, we can stick to rspec
defaults.

Developers can install custom formatting gems and specify that format in
their `.rspec-local` (added to gitignore here) if desired.

We get a *slight* bundle size reduction from removing the gem.
---
 .gitignore   | 3 +++
 .rspec       | 1 -
 Gemfile      | 3 ---
 Gemfile.lock | 4 ----
 4 files changed, 3 insertions(+), 8 deletions(-)

diff --git a/.gitignore b/.gitignore
index a70f30f9528..a74317bd7d8 100644
--- a/.gitignore
+++ b/.gitignore
@@ -71,3 +71,6 @@ docker-compose.override.yml
 
 # Ignore dotenv .local files
 .env*.local
+
+# Ignore local-only rspec configuration
+.rspec-local
diff --git a/.rspec b/.rspec
index 9a8e706d091..83e16f80447 100644
--- a/.rspec
+++ b/.rspec
@@ -1,3 +1,2 @@
 --color
 --require spec_helper
---format Fuubar
diff --git a/Gemfile b/Gemfile
index ef52d50cac1..51242414e8f 100644
--- a/Gemfile
+++ b/Gemfile
@@ -127,9 +127,6 @@ group :test do
   # Adds RSpec Error/Warning annotations to GitHub PRs on the Files tab
   gem 'rspec-github', '~> 2.4', require: false
 
-  # RSpec progress bar formatter
-  gem 'fuubar', '~> 2.5'
-
   # RSpec helpers for email specs
   gem 'email_spec'
 
diff --git a/Gemfile.lock b/Gemfile.lock
index c3e3adbbf3e..20c447d5458 100644
--- a/Gemfile.lock
+++ b/Gemfile.lock
@@ -284,9 +284,6 @@ GEM
     fugit (1.10.1)
       et-orbi (~> 1, >= 1.2.7)
       raabro (~> 1.4)
-    fuubar (2.5.1)
-      rspec-core (~> 3.0)
-      ruby-progressbar (~> 1.4)
     globalid (1.2.1)
       activesupport (>= 6.1)
     google-protobuf (3.25.3)
@@ -944,7 +941,6 @@ DEPENDENCIES
   flatware-rspec
   fog-core (<= 2.4.0)
   fog-openstack (~> 1.0)
-  fuubar (~> 2.5)
   haml-rails (~> 2.0)
   haml_lint
   hcaptcha (~> 7.1)