From 52540771b0e7f69d2d1e0c21b558976000e807e5 Mon Sep 17 00:00:00 2001
From: s0 <s0@s0.is>
Date: Fri, 16 Dec 2022 01:56:48 +1100
Subject: [PATCH] Fix crash in elasticsearch_check.rb (#21006)
Nil unwrap causes the admin dashboard to crash/500 when the Chewy client info version number value is nil.
This occurs when running another ES-compatible backend such as MeiliSearch.
Obviously it would be good for chewy to recognise upstream but at least avoiding the crash would be fine.
---
app/lib/admin/system_check/elasticsearch_check.rb | 1 +
1 file changed, 1 insertion(+)
diff --git a/app/lib/admin/system_check/elasticsearch_check.rb b/app/lib/admin/system_check/elasticsearch_check.rb
index 8aee182674b..a63988224b2 100644
--- a/app/lib/admin/system_check/elasticsearch_check.rb
+++ b/app/lib/admin/system_check/elasticsearch_check.rb
@@ -34,6 +34,7 @@ class Admin::SystemCheck::ElasticsearchCheck < Admin::SystemCheck::BaseCheck
end
def compatible_version?
+ return false if running_version.nil?
Gem::Version.new(running_version) >= Gem::Version.new(required_version)
end
end