From 7ac305367360f256d2d679f7e215aeb0c4d94130 Mon Sep 17 00:00:00 2001 From: Adam Niedzielski Date: Mon, 29 Jul 2024 14:54:41 +0200 Subject: [PATCH] Fix failing specs --- spec/models/concerns/account/counters_spec.rb | 14 ++++++-------- spec/requests/api/v1/directories_spec.rb | 18 +++++++++--------- 2 files changed, 15 insertions(+), 17 deletions(-) diff --git a/spec/models/concerns/account/counters_spec.rb b/spec/models/concerns/account/counters_spec.rb index ccac9e95de6..036b7b99e93 100644 --- a/spec/models/concerns/account/counters_spec.rb +++ b/spec/models/concerns/account/counters_spec.rb @@ -46,16 +46,14 @@ describe Account::Counters do end it 'preserves last_status_at when decrementing statuses_count' do - account_stat = Fabricate( - :account_stat, - account: account, - last_status_at: 3.days.ago, - statuses_count: 10 - ) + account.statuses_count = 10 + account.save! + account.account_stat.last_status_at = 3.days.ago + account.account_stat.save! expect { account.decrement_count!(:statuses_count) } - .to change(account_stat.reload, :statuses_count).by(-1) - .and not_change(account_stat.reload, :last_status_at) + .to change(account.account_stat.reload, :statuses_count).by(-1) + .and not_change(account.account_stat.reload, :last_status_at) end end end diff --git a/spec/requests/api/v1/directories_spec.rb b/spec/requests/api/v1/directories_spec.rb index 0a1864d136c..286fcbecc5a 100644 --- a/spec/requests/api/v1/directories_spec.rb +++ b/spec/requests/api/v1/directories_spec.rb @@ -17,7 +17,7 @@ describe 'Directories API' do user: Fabricate(:user, confirmed_at: nil, approved: true), username: 'local_unconfirmed' ) - local_unconfirmed_account.create_account_stat! + local_unconfirmed_account.account_stat.save! local_unapproved_account = Fabricate( :account, @@ -25,7 +25,7 @@ describe 'Directories API' do user: Fabricate(:user, confirmed_at: 10.days.ago), username: 'local_unapproved' ) - local_unapproved_account.create_account_stat! + local_unapproved_account.account_stat.save! local_unapproved_account.user.update(approved: false) local_undiscoverable_account = Fabricate( @@ -35,7 +35,7 @@ describe 'Directories API' do discoverable: false, username: 'local_undiscoverable' ) - local_undiscoverable_account.create_account_stat! + local_undiscoverable_account.account_stat.save! excluded_from_timeline_account = Fabricate( :account, @@ -43,7 +43,7 @@ describe 'Directories API' do discoverable: true, username: 'remote_excluded_from_timeline' ) - excluded_from_timeline_account.create_account_stat! + excluded_from_timeline_account.account_stat.save! Fabricate(:block, account: user.account, target_account: excluded_from_timeline_account) domain_blocked_account = Fabricate( @@ -52,11 +52,11 @@ describe 'Directories API' do discoverable: true, username: 'remote_domain_blocked' ) - domain_blocked_account.create_account_stat! + domain_blocked_account.account_stat.save! Fabricate(:account_domain_block, account: user.account, domain: 'test.example') - local_discoverable_account.create_account_stat! - eligible_remote_account.create_account_stat! + local_discoverable_account.account_stat.save! + eligible_remote_account.account_stat.save! end let(:local_discoverable_account) do @@ -93,8 +93,8 @@ describe 'Directories API' do let(:remote_account) { Fabricate(:account, domain: 'host.example') } before do - local_account.create_account_stat! - remote_account.create_account_stat! + local_account.account_stat.save! + remote_account.account_stat.save! end it 'returns only the local accounts' do