From a25014de8fae061f191c95608aabe3d6d02ac45d Mon Sep 17 00:00:00 2001
From: Daniel M Brasil <danielmbrasil@protonmail.com>
Date: Fri, 1 Mar 2024 13:17:40 -0300
Subject: [PATCH] Improve `IpBlock` model test coverage (#29460)

---
 spec/models/ip_block_spec.rb | 53 +++++++++++++++++++++++++++++++++++-
 1 file changed, 52 insertions(+), 1 deletion(-)

diff --git a/spec/models/ip_block_spec.rb b/spec/models/ip_block_spec.rb
index ed58826672e..290b99b2884 100644
--- a/spec/models/ip_block_spec.rb
+++ b/spec/models/ip_block_spec.rb
@@ -3,7 +3,32 @@
 require 'rails_helper'
 
 describe IpBlock do
-  describe 'to_log_human_identifier' do
+  describe 'validations' do
+    it 'validates ip presence', :aggregate_failures do
+      ip_block = described_class.new(ip: nil, severity: :no_access)
+
+      expect(ip_block).to_not be_valid
+      expect(ip_block).to model_have_error_on_field(:ip)
+    end
+
+    it 'validates severity presence', :aggregate_failures do
+      ip_block = described_class.new(ip: '127.0.0.1', severity: nil)
+
+      expect(ip_block).to_not be_valid
+      expect(ip_block).to model_have_error_on_field(:severity)
+    end
+
+    it 'validates ip uniqueness', :aggregate_failures do
+      described_class.create!(ip: '127.0.0.1', severity: :no_access)
+
+      ip_block = described_class.new(ip: '127.0.0.1', severity: :no_access)
+
+      expect(ip_block).to_not be_valid
+      expect(ip_block).to model_have_error_on_field(:ip)
+    end
+  end
+
+  describe '#to_log_human_identifier' do
     let(:ip_block) { described_class.new(ip: '192.168.0.1') }
 
     it 'combines the IP and prefix into a string' do
@@ -12,4 +37,30 @@ describe IpBlock do
       expect(result).to eq('192.168.0.1/32')
     end
   end
+
+  describe '.blocked?' do
+    context 'when the IP is blocked' do
+      it 'returns true' do
+        described_class.create!(ip: '127.0.0.1', severity: :no_access)
+
+        expect(described_class.blocked?('127.0.0.1')).to be true
+      end
+    end
+
+    context 'when the IP is not blocked' do
+      it 'returns false' do
+        expect(described_class.blocked?('127.0.0.1')).to be false
+      end
+    end
+  end
+
+  describe 'after_commit' do
+    it 'resets the cache' do
+      allow(Rails.cache).to receive(:delete)
+
+      described_class.create!(ip: '127.0.0.1', severity: :no_access)
+
+      expect(Rails.cache).to have_received(:delete).with(described_class::CACHE_KEY)
+    end
+  end
 end