erik/mastodon
1
0
Fork 0
mirror of https://github.com/mastodon/mastodon.git synced 2024-08-20 21:08:15 -07:00
Code Issues Projects Releases Wiki Activity

Wrong type for user setting when default is defined by lambda (#24321)

Browse source
This commit is contained in:
Christian Schmidt 2023-03-31 07:33:17 +02:00 committed by GitHub
parent 68a192e718
commit b4f38edf74
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 34 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
app/models/user_settings/setting.rb
View file

@ -19,7 +19,8 @@ class UserSettings::Setting
end
def type
if @default_value.is_a?(TrueClass) || @default_value.is_a?(FalseClass)
case default_value
when TrueClass, FalseClass
ActiveModel::Type::Boolean.new
else
ActiveModel::Type::String.new

32
spec/models/user_settings/setting_spec.rb
View file

@ -30,6 +30,38 @@ RSpec.describe UserSettings::Setting do
it 'returns a type' do
expect(subject.type).to be_a ActiveModel::Type::Value
end
context 'when default value is a boolean' do
let(:default) { false }
it 'returns boolean' do
expect(subject.type).to be_a ActiveModel::Type::Boolean
end
end
context 'when default value is a string' do
let(:default) { '' }
it 'returns string' do
expect(subject.type).to be_a ActiveModel::Type::String
end
end
context 'when default value is a lambda returning a boolean' do
let(:default) { -> { false } }
it 'returns boolean' do
expect(subject.type).to be_a ActiveModel::Type::Boolean
end
end
context 'when default value is a lambda returning a string' do
let(:default) { -> { '' } }
it 'returns boolean' do
expect(subject.type).to be_a ActiveModel::Type::String
end
end
end
describe '#type_cast' do