Merge 52c56ed5a6 into a50c8e951f

app/javascript/mastodon/api_types/notifications.ts

@@ -60,7 +60,7 @@ export interface BaseNotificationGroupJSON {
 
 interface NotificationGroupWithStatusJSON extends BaseNotificationGroupJSON {
   type: NotificationWithStatusType;
-  status: ApiStatusJSON;
+  status_id: string;
 }
 
 interface NotificationWithStatusJSON extends BaseNotificationJSON {

app/javascript/mastodon/features/notifications/components/filtered_notifications_banner.tsx

@@ -49,21 +49,14 @@ export const FilteredNotificationsBanner: React.FC = () => {
         <span>
           <FormattedMessage
             id='filtered_notifications_banner.pending_requests'
-            defaultMessage='Notifications from {count, plural, =0 {no one} one {one person} other {# people}} you may know'
+            defaultMessage='From {count, plural, =0 {no one} one {one person} other {# people}} you may know'
             values={{ count: policy.summary.pending_requests_count }}
           />
         </span>
       </div>
 
       <div className='filtered-notifications-banner__badge'>
-        <div className='filtered-notifications-banner__badge__badge'>
-          {toCappedNumber(policy.summary.pending_notifications_count)}
-        </div>
-        <FormattedMessage
-          id='filtered_notifications_banner.mentions'
-          defaultMessage='{count, plural, one {mention} other {mentions}}'
-          values={{ count: policy.summary.pending_notifications_count }}
-        />
+        {toCappedNumber(policy.summary.pending_notifications_count)}
       </div>
     </Link>
   );

app/javascript/mastodon/locales/en.json

@@ -300,8 +300,7 @@
   "filter_modal.select_filter.subtitle": "Use an existing category or create a new one",
   "filter_modal.select_filter.title": "Filter this post",
   "filter_modal.title.status": "Filter a post",
-  "filtered_notifications_banner.mentions": "{count, plural, one {mention} other {mentions}}",
-  "filtered_notifications_banner.pending_requests": "Notifications from {count, plural, =0 {no one} one {one person} other {# people}} you may know",
+  "filtered_notifications_banner.pending_requests": "From {count, plural, =0 {no one} one {one person} other {# people}} you may know",
   "filtered_notifications_banner.title": "Filtered notifications",
   "firehose.all": "All",
   "firehose.local": "This server",

app/javascript/mastodon/models/notification_group.ts

@@ -124,9 +124,9 @@ export function createNotificationGroupFromJSON(
     case 'mention':
     case 'poll':
     case 'update': {
-      const { status, ...groupWithoutStatus } = group;
+      const { status_id: statusId, ...groupWithoutStatus } = group;
       return {
-        statusId: status.id,
+        statusId,
         sampleAccountIds,
         ...groupWithoutStatus,
       };

app/javascript/styles/mastodon/components.scss

@@ -10171,25 +10171,10 @@ noscript {
   }
 
   &__badge {
-    display: flex;
-    align-items: center;
-    border-radius: 999px;
-    background: var(--background-border-color);
-    color: $darker-text-color;
-    padding: 4px;
-    padding-inline-end: 8px;
-    gap: 6px;
-    font-weight: 500;
-    font-size: 11px;
-    line-height: 16px;
-    word-break: keep-all;
-
-    &__badge {
-      background: $ui-button-background-color;
-      color: $white;
-      border-radius: 100px;
-      padding: 2px 8px;
-    }
+    background: $ui-button-background-color;
+    color: $white;
+    border-radius: 100px;
+    padding: 2px 8px;
   }
 }
 

app/lib/activitypub/activity/create.rb

@@ -88,6 +88,7 @@ class ActivityPub::Activity::Create < ActivityPub::Activity
     end
 
     resolve_thread(@status)
+    fixup_thread(@status)
     fetch_replies(@status)
     distribute
     forward_for_reply
@@ -334,6 +335,10 @@ class ActivityPub::Activity::Create < ActivityPub::Activity
     ThreadResolveWorker.perform_async(status.id, in_reply_to_uri, { 'request_id' => @options[:request_id] })
   end
 
+  def fixup_thread(status)
+    ThreadRepair.new(status.uri).reattach_orphaned_children!(status)
+  end
+
   def fetch_replies(status)
     collection = @object['replies']
     return if collection.nil?

app/lib/thread_repair.rb

@@ -0,0 +1,44 @@
+# frozen_string_literal: true
+
+class ThreadRepair
+  include Redisable
+
+  THREAD_FIXUP_WINDOW = 1.hour.to_i
+
+  def initialize(parent_uri)
+    @parent_uri = parent_uri
+  end
+
+  def find_parent(child_id)
+    with_redis do |redis|
+      redis.sadd(redis_key, child_id)
+      redis.expire(redis_key, THREAD_FIXUP_WINDOW)
+
+      parent = ActivityPub::TagManager.instance.uri_to_resource(@parent_uri, Status)
+      redis.srem(redis_key, child_id) if parent.present?
+
+      parent
+    end
+  end
+
+  def reattach_orphaned_children!(parent)
+    with_redis do |redis|
+      redis.sscan_each(redis_key, count: 1000) do |ids|
+        statuses = Status.where(id: ids).to_a
+
+        statuses.each { |status| status.update(thread: parent) }
+
+        # Updated statuses need to be distributed to clients/inserted in TLs
+        DistributionWorker.push_bulk(statuses.filter(&:within_realtime_window?)) do |status|
+          [status.id, { 'skip_notifications' => true }]
+        end
+
+        redis.srem(redis_key, ids)
+      end
+    end
+  end
+
+  def redis_key
+    "thread_repair:#{@parent_uri}"
+  end
+end

app/workers/thread_resolve_worker.rb

@@ -13,6 +13,11 @@ class ThreadResolveWorker
     parent_status = ActivityPub::TagManager.instance.uri_to_resource(parent_url, Status)
     parent_status ||= FetchRemoteStatusService.new.call(parent_url, **options.deep_symbolize_keys)
 
+    # The parent post does not exist or is private, so take note of it so the thread can be
+    # reconstructed if the parent arrives.
+    # This will re-check the database to avoid race conditions
+    parent_status ||= ThreadRepair.new(parent_url).find_parent(child_status_id)
+
     return if parent_status.nil?
 
     child_status.thread = parent_status