1
0
Fork 0
mirror of https://github.com/mastodon/mastodon.git synced 2024-08-20 21:08:15 -07:00
mastodon/app
Claire 526332c545
Fix account deletion sometimes failing because of optimistic locks (#16317)
* Fix account deletion sometimes failing because of optimistic locks

In some rare occasions[1], deleting accounts would fail with a
`StaleObjectError` exception.

Indeed, account deletion manually sets the `AccountStat` values without
handling cases where the optimistic locking on `AccountStat` would fail.

To my knowledge, with the rewrite of account counters in #15913, the
`DeleteAccountService` is now the only place that changes the counters in
a way that is not atomic.

Since in this specific case, we do not care about the previous values of the
account counters, it appears we don't need locking at all for this table
anymore.

[1]: https://discourse.joinmastodon.org/t/account-cant-be-deleted/3602

* Bump MAX_SUPPORTED_VERSION in maintenance script
2021-06-02 17:41:25 +02:00
..
chewy Change tootctl search deploy algorithm (#14300) 2020-07-14 18:10:35 +02:00
controllers Fix some IDs in instance actor outbox (#16343) 2021-05-31 22:59:30 +02:00
helpers New Crowdin updates (#16269) 2021-05-20 00:19:52 +02:00
javascript Fix deprecated slash as division in SASS files (#16347) 2021-06-01 23:47:27 +02:00
lib Fix some RedisLocks auto-releasing too fast (#16276) 2021-05-19 23:52:08 +02:00
mailers Prepare Mastodon for Rails 6 (#15911) 2021-03-17 10:09:55 +01:00
models Fix account deletion sometimes failing because of optimistic locks (#16317) 2021-06-02 17:41:25 +02:00
policies Add management of delivery availability in Federation settings (#15771) 2021-05-05 23:39:02 +02:00
presenters Add server rules (#15769) 2021-02-21 19:50:12 +01:00
serializers Add width and height to attachments in ActivityPub (#16245) 2021-05-16 23:09:03 +02:00
services Fix some RedisLocks auto-releasing too fast (#16276) 2021-05-19 23:52:08 +02:00
validators Fix existing username validator not allowing multiple accounts (#16153) 2021-05-04 14:22:04 +02:00
views Change trending hashtags to be affected be reblogs (#16164) 2021-05-07 14:33:43 +02:00
workers Fix some RedisLocks auto-releasing too fast (#16276) 2021-05-19 23:52:08 +02:00