teh/mastodon
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 10

Autofix Rubocop Security/IoMethods (#23757)

Browse source
This commit is contained in:
Nick Schonning 2023-02-20 13:21:19 -05:00 committed by GitHub
parent 9909b4b653
commit 35d032500b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 3 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
.rubocop_todo.yml
View file

@ -1956,13 +1956,6 @@ Rails/WhereExists:
- 'spec/services/purge_domain_service_spec.rb' - 'spec/services/purge_domain_service_spec.rb'
- 'spec/services/unallow_domain_service_spec.rb' - 'spec/services/unallow_domain_service_spec.rb'
# Offense count: 3
# This cop supports unsafe autocorrection (--autocorrect-all).
Security/IoMethods:
Exclude:
- 'spec/controllers/admin/export_domain_allows_controller_spec.rb'
- 'spec/controllers/admin/export_domain_blocks_controller_spec.rb'
# Offense count: 5 # Offense count: 5
# This cop supports unsafe autocorrection (--autocorrect-all). # This cop supports unsafe autocorrection (--autocorrect-all).
Style/CaseLikeIf: Style/CaseLikeIf:

4
spec/controllers/admin/export_domain_allows_controller_spec.rb
View file

@ -14,7 +14,7 @@ RSpec.describe Admin::ExportDomainAllowsController, type: :controller do
get :export, params: { format: :csv } get :export, params: { format: :csv }
expect(response).to have_http_status(200) expect(response).to have_http_status(200)
expect(response.body).to eq(IO.read(File.join(file_fixture_path, 'domain_allows.csv'))) expect(response.body).to eq(File.read(File.join(file_fixture_path, 'domain_allows.csv')))
end end
end end
@ -30,7 +30,7 @@ RSpec.describe Admin::ExportDomainAllowsController, type: :controller do
# Domains should now be added # Domains should now be added
get :export, params: { format: :csv } get :export, params: { format: :csv }
expect(response).to have_http_status(200) expect(response).to have_http_status(200)
expect(response.body).to eq(IO.read(File.join(file_fixture_path, 'domain_allows.csv'))) expect(response.body).to eq(File.read(File.join(file_fixture_path, 'domain_allows.csv')))
end end
it 'displays error on no file selected' do it 'displays error on no file selected' do

2
spec/controllers/admin/export_domain_blocks_controller_spec.rb
View file

@ -16,7 +16,7 @@ RSpec.describe Admin::ExportDomainBlocksController, type: :controller do
get :export, params: { format: :csv } get :export, params: { format: :csv }
expect(response).to have_http_status(200) expect(response).to have_http_status(200)
expect(response.body).to eq(IO.read(File.join(file_fixture_path, 'domain_blocks.csv'))) expect(response.body).to eq(File.read(File.join(file_fixture_path, 'domain_blocks.csv')))
end end
end end